Issue 523164: License cleanup for http://code.google.com/p/gyp/issues/detail?id=133...

Issue 523164: License cleanup for http://code.google.com/p/gyp/issues/detail?id=133... (Closed)

Created:
10 years, 11 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

Description

License cleanup for http://code.google.com/p/gyp/issues/detail?id=133 TEST=none BUG=http://code.google.com/p/gyp/issues/detail?id=133 Committed: http://code.google.com/p/gyp/source/detail?r=771

Patch Set 1 #

Total comments: 8

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -15 lines)			Patch
M	gyp_dummy.c	View	1 chunk	+5 lines, -0 lines	1 comment	Download
M	setup.py	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	test/defines/defines.c	View	1 chunk	+5 lines, -0 lines	1 comment	Download
M	test/dependencies/a.c	View	1 chunk	+5 lines, -0 lines	1 comment	Download
M	test/hello/hello.c	View	1 chunk	+5 lines, -0 lines	1 comment	Download
M	test/hello/hello2.c	View	1 chunk	+5 lines, -0 lines	1 comment	Download
M	test/rules-rebuild/gyptest-all.py	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	test/rules-rebuild/gyptest-default.py	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	test/scons_tools/tools.c	View	1 chunk	+5 lines, -0 lines	1 comment	Download
M	test/toolsets/main.cc	View	1 chunk	+5 lines, -0 lines	1 comment	Download
M	test/toolsets/toolsets.cc	View	1 chunk	+5 lines, -0 lines	1 comment	Download
M	test/variables/update_golden	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tools/pretty_sln.py	View	4 chunks	+8 lines, -6 lines	0 comments	Download
M	tools/pretty_vcproj.py	View	5 chunks	+11 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

10 years, 11 months ago (2010-01-08 14:54:57 UTC) #2

lgtm

http://codereview.chromium.org/523164/diff/1/15
File gyp_dummy.c (right):

http://codereview.chromium.org/523164/diff/1/15#newcode3
gyp_dummy.c:3: * found in the LICENSE file.
Can you */ on this line to take up slightly less space?

http://codereview.chromium.org/523164/diff/1/11
File test/defines/defines.c (right):

http://codereview.chromium.org/523164/diff/1/11#newcode3
test/defines/defines.c:3: * found in the LICENSE file.
Same.

http://codereview.chromium.org/523164/diff/1/2
File test/dependencies/a.c (right):

http://codereview.chromium.org/523164/diff/1/2#newcode3
test/dependencies/a.c:3: * found in the LICENSE file.
Same.

http://codereview.chromium.org/523164/diff/1/7
File test/hello/hello.c (right):

http://codereview.chromium.org/523164/diff/1/7#newcode3
test/hello/hello.c:3: * found in the LICENSE file.
Same.

http://codereview.chromium.org/523164/diff/1/8
File test/hello/hello2.c (right):

http://codereview.chromium.org/523164/diff/1/8#newcode3
test/hello/hello2.c:3: * found in the LICENSE file.
Same.

http://codereview.chromium.org/523164/diff/1/3
File test/scons_tools/tools.c (right):

http://codereview.chromium.org/523164/diff/1/3#newcode3
test/scons_tools/tools.c:3: * found in the LICENSE file.
Same.

http://codereview.chromium.org/523164/diff/1/10
File test/toolsets/main.cc (right):

http://codereview.chromium.org/523164/diff/1/10#newcode3
test/toolsets/main.cc:3: * found in the LICENSE file.
Same.

http://codereview.chromium.org/523164/diff/1/9
File test/toolsets/toolsets.cc (right):

http://codereview.chromium.org/523164/diff/1/9#newcode3
test/toolsets/toolsets.cc:3: * found in the LICENSE file.
Same.

Expand Messages | Collapse Messages