Issue 523149: Revert 35735 - Relanding the language detection code....

Issue 523149: Revert 35735 - Relanding the language detection code.... (Closed)

Created:
10 years, 11 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, Erik does not do reviews, jam, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin (slow to review)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 35735 - Relanding the language detection code. Still causes redness on the reliability bot. The code would crash if multiple PageContents notifications were received rapidly. The CLDHelper now notifies the TabContents directly and the TabContents ensures only one language detection can be performed at a time. Added unittests to validate these cases in web_contents_unittest.cc. Note that patch set 1 is the original patch, patch set 2 contains the new changes. Original review: http://codereview.chromium.org/492024/show BUG=30662 TEST=Run the unittests. Review URL: http://codereview.chromium.org/504051 TBR=jcampan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35753

Patch Set 1 #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+129 lines, -473 lines)			Patch
M	chrome/browser/browser.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/browser_browsertest.cc	View	1 chunk	+0 lines, -33 lines	0 comments	Download
D	chrome/browser/cld_helper.h	View	1 chunk	+0 lines, -72 lines	0 comments	Download
D	chrome/browser/cld_helper.cc	View	1 chunk	+0 lines, -70 lines	0 comments	Download
M	chrome/browser/extensions/extension_tabs_module.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_tabs_module.cc	View	2 chunks	+9 lines, -25 lines	0 comments	Download
M	chrome/browser/renderer_host/browser_render_process_host.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/browser_render_process_host.cc	View	3 chunks	+15 lines, -2 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.h	View	4 chunks	+12 lines, -8 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.cc	View	6 chunks	+24 lines, -11 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host_delegate.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/tab_contents/navigation_entry.h	View	2 chunks	+0 lines, -10 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.h	View	5 chunks	+3 lines, -11 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.cc	View	4 chunks	+4 lines, -53 lines	0 comments	Download
M	chrome/browser/tab_contents/web_contents_unittest.cc	View	4 chunks	+1 line, -103 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/common/notification_type.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/common/render_messages_internal.h	View	4 chunks	+14 lines, -8 lines	0 comments	Download
M	chrome/renderer/render_view.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View	5 chunks	+38 lines, -5 lines	0 comments	Download
D	chrome/test/data/english_page.html	View	1 chunk	+0 lines, -6 lines	0 comments	Download
D	chrome/test/data/french_page.html	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/test/ui_test_utils.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/test/ui_test_utils.cc	View	2 chunks	+0 lines, -32 lines	0 comments	Download