Issue 523147: Made MenuController handle dynamic labels.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 523147: Made MenuController handle dynamic labels. (Closed)

Created:
10 years, 11 months ago by akalin

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Made MenuController handle dynamic labels. Made AppMenuModel handle sync item dynamically. BUG=31691 TEST=made sure wrench menu item dynamically updates sync menu item Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35821

Patch Set 1 #

Patch Set 2 : Added comments and DCHECK. #

Patch Set 3 : Fixed lint error. #

Total comments: 1

Patch Set 4 : Addressed pinkerton's comments. #

Created: 10 years, 11 months ago

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -5 lines)
M	chrome/browser/app_menu_model.h	View	1 chunk	+11 lines, -0 lines	0 comments
M	chrome/browser/app_menu_model.cc	View	3 chunks	+34 lines, -5 lines	0 comments
M	chrome/browser/cocoa/menu_controller.mm	View	1 chunk	+5 lines, -0 lines	0 comments

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pink (ping after 24hrs)

Nice catch. LGTM. http://codereview.chromium.org/523147/diff/1002/1004 File chrome/browser/app_menu_model.h (right): http://codereview.chromium.org/523147/diff/1002/1004#newcode23 chrome/browser/app_menu_model.h:23: // We override this to handle ...

10 years, 11 months ago (2010-01-08 15:48:31 UTC) #2

akalin (wrong akalin)

10 years, 11 months ago (2010-01-08 20:34:59 UTC) #3

On Fri, Jan 8, 2010 at 7:48 AM,  <pinkerton@chromium.org> wrote:
> Nice catch. LGTM.
>
>
> http://codereview.chromium.org/523147/diff/1002/1004#newcode23
> chrome/browser/app_menu_model.h:23: // We override this to handle the
> sync menu item (whose label is
> Omit "we". Just "Override this..."

Done, submitting.

-- 
Frederick Akalin
Software Engineer

Expand Messages | Collapse Messages