chrome/browser/privacy_blacklist/blacklist_io.cc - Issue 523138: Make the error_string parameter a reference instead of a pointer to enforce

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/privacy_blacklist/blacklist_io.cc

Issue 523138: Make the error_string parameter a reference instead of a pointer to enforce (Closed)

Patch Set: use DCHECK instead. Created 10 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/privacy_blacklist/blacklist_io.cc

diff --git a/chrome/browser/privacy_blacklist/blacklist_io.cc b/chrome/browser/privacy_blacklist/blacklist_io.cc

index b6ff2606b1f66357b8ca8223a6ff55db0c520533..10f09dc54a485df34c106198c1adb544ea1e21aa 100644

--- a/chrome/browser/privacy_blacklist/blacklist_io.cc

+++ b/chrome/browser/privacy_blacklist/blacklist_io.cc

@@ -47,6 +47,7 @@ bool BlacklistIO::ReadText(Blacklist* blacklist,

const FilePath& path,

std::string* error_string) {

DCHECK(blacklist);

+ DCHECK(error_string);

// Memory map for efficient parsing. If the file cannot fit in available

// memory it would be the least of our worries. Typical blacklist files

« no previous file with comments | « no previous file | no next file » | no next file with comments »