Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: chrome/browser/privacy_blacklist/blacklist_io_unittest.cc

Issue 523137: Also match against the query string if present. (Closed)
Patch Set: updates Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/privacy_blacklist/blacklist_io_unittest.cc
diff --git a/chrome/browser/privacy_blacklist/blacklist_io_unittest.cc b/chrome/browser/privacy_blacklist/blacklist_io_unittest.cc
index 20607bf551c3e12731744e9ef97234cf95e18987..e92e120491f589354fb1dcdf87183d6d2e9f9a01 100644
--- a/chrome/browser/privacy_blacklist/blacklist_io_unittest.cc
+++ b/chrome/browser/privacy_blacklist/blacklist_io_unittest.cc
@@ -25,17 +25,19 @@ TEST(BlacklistIOTest, Generic) {
std::string error_string;
ASSERT_TRUE(BlacklistIO::ReadText(&blacklist, input, &error_string));
EXPECT_TRUE(error_string.empty());
-
+
const Blacklist::EntryList entries(blacklist.entries_begin(),
blacklist.entries_end());
- ASSERT_EQ(5U, entries.size());
+ ASSERT_EQ(7U, entries.size());
EXPECT_EQ("@", entries[0]->pattern());
EXPECT_EQ("@poor-security-site.com", entries[1]->pattern());
EXPECT_EQ("@.ad-serving-place.com", entries[2]->pattern());
EXPECT_EQ("www.site.com/anonymous/folder/@", entries[3]->pattern());
EXPECT_EQ("www.site.com/bad/url", entries[4]->pattern());
-
+ EXPECT_EQ("@/script?@", entries[5]->pattern());
+ EXPECT_EQ("@?badparam@", entries[6]->pattern());
+
const Blacklist::ProviderList providers(blacklist.providers_begin(),
blacklist.providers_end());

Powered by Google App Engine
This is Rietveld 408576698