Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Side by Side Diff: chrome/common/extensions/extension_constants.cc

Issue 523132: Allow an empty list of page actions. (Closed)
Patch Set: '' Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/extensions/extension.cc ('k') | chrome/common/extensions/extension_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/extension_constants.h" 5 #include "chrome/common/extensions/extension_constants.h"
6 6
7 namespace extension_manifest_keys { 7 namespace extension_manifest_keys {
8 8
9 const wchar_t* kAllFrames = L"all_frames"; 9 const wchar_t* kAllFrames = L"all_frames";
10 const wchar_t* kBackground = L"background_page"; 10 const wchar_t* kBackground = L"background_page";
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 "Required value 'name' is missing or invalid."; 115 "Required value 'name' is missing or invalid.";
116 const char* kInvalidPageAction = 116 const char* kInvalidPageAction =
117 "Invalid value for 'page_action'."; 117 "Invalid value for 'page_action'.";
118 const char* kInvalidPageActionName = 118 const char* kInvalidPageActionName =
119 "Invalid value for 'page_action.name'."; 119 "Invalid value for 'page_action.name'.";
120 const char* kInvalidPageActionIconPath = 120 const char* kInvalidPageActionIconPath =
121 "Invalid value for 'page_action.default_icon'."; 121 "Invalid value for 'page_action.default_icon'.";
122 const char* kInvalidPageActionsList = 122 const char* kInvalidPageActionsList =
123 "Invalid value for 'page_actions'."; 123 "Invalid value for 'page_actions'.";
124 const char* kInvalidPageActionsListSize = 124 const char* kInvalidPageActionsListSize =
125 "Invalid value for 'page_actions'. There can be only one."; 125 "Invalid value for 'page_actions'. There can be at most one page action.";
126 const char* kInvalidPageActionId = 126 const char* kInvalidPageActionId =
127 "Required value 'id' is missing or invalid."; 127 "Required value 'id' is missing or invalid.";
128 const char* kInvalidPageActionDefaultTitle = 128 const char* kInvalidPageActionDefaultTitle =
129 "Invalid value for 'default_title'."; 129 "Invalid value for 'default_title'.";
130 const char* kInvalidPageActionPopup = 130 const char* kInvalidPageActionPopup =
131 "Invalid type for page action popup."; 131 "Invalid type for page action popup.";
132 const char* kInvalidPageActionPopupHeight = 132 const char* kInvalidPageActionPopupHeight =
133 "Invalid value for page action popup height [*]."; 133 "Invalid value for page action popup height [*].";
134 const char* kInvalidPageActionPopupPath = 134 const char* kInvalidPageActionPopupPath =
135 "Invalid value for page action popup path [*]."; 135 "Invalid value for page action popup path [*].";
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
205 "Invalid value for 'options_page'."; 205 "Invalid value for 'options_page'.";
206 } // namespace extension_manifest_errors 206 } // namespace extension_manifest_errors
207 207
208 namespace extension_urls { 208 namespace extension_urls {
209 const char* kGalleryBrowsePrefix = "https://chrome.google.com/extensions"; 209 const char* kGalleryBrowsePrefix = "https://chrome.google.com/extensions";
210 const char* kGalleryDownloadPrefix = 210 const char* kGalleryDownloadPrefix =
211 "https://clients2.googleusercontent.com/crx/download"; 211 "https://clients2.googleusercontent.com/crx/download";
212 const char* kMiniGalleryBrowsePrefix = "https://tools.google.com/chrome/"; 212 const char* kMiniGalleryBrowsePrefix = "https://tools.google.com/chrome/";
213 const char* kMiniGalleryDownloadPrefix = "https://dl-ssl.google.com/chrome/"; 213 const char* kMiniGalleryDownloadPrefix = "https://dl-ssl.google.com/chrome/";
214 } 214 }
OLDNEW
« no previous file with comments | « chrome/common/extensions/extension.cc ('k') | chrome/common/extensions/extension_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698