Issue 523094: Fix checkout root detection for git

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 523094: Fix checkout root detection for git (Closed)

Created:
10 years, 11 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix checkout root detection for git. Add shorthand parameters. Stop changing the logging level in gcl and some logging changes. Change SCM.GetCheckoutRoot() to SCM.checkout_root. TEST=none BUG=none

Patch Set 1 #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -49 lines)			Patch
M	gclient_utils.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	scm.py	View	1 chunk	+4 lines, -6 lines	0 comments	Download
M	tests/trychange_unittest.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trychange.py	View	16 chunks	+40 lines, -39 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages