Avoid accepting suspiciously long URLs from the renderer. These can take down...

chrome/common/common_param_traits.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/common_param_traits.h"
 
 #include "base/gfx/rect.h"
+#include "chrome/common/chrome_constants.h"
 #include "googleurl/src/gurl.h"
 #ifndef EXCLUDE_SKIA_DEPENDENCIES
 #include "third_party/skia/include/core/SkBitmap.h"
 #endif
 #include "webkit/glue/dom_operations.h"
 
 namespace IPC {
 
 #ifndef EXCLUDE_SKIA_DEPENDENCIES
 
@@ skipping 74 matching lines @@
 
 #endif  // EXCLUDE_SKIA_DEPENDENCIES
 
 void ParamTraits<GURL>::Write(Message* m, const GURL& p) {
   m->WriteString(p.possibly_invalid_spec());
   // TODO(brettw) bug 684583: Add encoding for query params.
 }
 
 bool ParamTraits<GURL>::Read(const Message* m, void** iter, GURL* p) {
   std::string s;
-  if (!m->ReadString(iter, &s)) {
+  if (!m->ReadString(iter, &s) || s.length() > chrome::kMaxURLChars) {
     *p = GURL();
     return false;
   }
   *p = GURL(s);
   return true;
 }
 
 void ParamTraits<GURL>::Log(const GURL& p, std::wstring* l) {
   l->append(UTF8ToWide(p.spec()));
 }
@@ skipping 101 matching lines @@
   return true;
 }
 
 void ParamTraits<webkit_glue::WebApplicationInfo>::Log(
     const webkit_glue::WebApplicationInfo& p, std::wstring* l) {
   l->append(L"<WebApplicationInfo>");
 }
 
 }  // namespace IPC