Clear the host cache when closing the last incognito window....

Clear the host cache when closing the last incognito window.
This avoids retaining navigation history relating to the incognito window.

I piggy-back off of the dns prefetcher's OffTheRecordObserver to do this. In the future I hope to have a separate host resolver for off the record mode, so this won't be necessary.

BUG=24629
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35923

[eroman, 2010-01-08 23:55:52]

ping

[jar (doing other things), 2010-01-09 00:18:55]

Please consider renaming the function as mentioned below, and augmenting the
comment in browser_main.cc

http://codereview.chromium.org/523076/diff/12/15
File chrome/browser/net/dns_global.cc (right):

http://codereview.chromium.org/523076/diff/12/15#newcode617
chrome/browser/net/dns_global.cc:617:
DnsPrefetcherInit::DnsPrefetcherInit(PrefService* user_prefs,
Given that this now "helps" with DNS resolver initialization, perhaps its name
should be changed?  DnsSubsystemsInit?

The call (constructor) in browser_main.cc should also have their comment amended
so that the urge to disable from that point does not take hold.

[eroman, 2010-01-09 01:50:24]

Thanks for the review.

Done: Renamed DnsPrefetcherInit --> DnsGlobalInit

[jar (doing other things), 2010-01-09 02:16:29]

One nit below.

LGTM with that fixed.

Thanks!

http://codereview.chromium.org/523076/diff/7001/7005
File chrome/browser/browser_main.cc (right):

http://codereview.chromium.org/523076/diff/7001/7005#newcode766
chrome/browser/browser_main.cc:766: // to clear the host cache when closing
incognito mode
nit: period at end of sentence.