Issue 523051: Make the ResolvePossiblyDirectEval faster by avoiding the...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 523051: Make the ResolvePossiblyDirectEval faster by avoiding the... (Closed)

Created:
10 years, 11 months ago by Kasper Lund

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium), Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Make the ResolvePossiblyDirectEval faster by avoiding the stack traversal code. Committed: http://code.google.com/p/v8/source/detail?r=3533

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -108 lines)			Patch
M	src/arm/codegen-arm.cc	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	src/bootstrapper.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/contexts.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View		1 chunk	+10 lines, -13 lines	0 comments	Download
M	src/runtime.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime.cc	View	1	2 chunks	+44 lines, -68 lines	0 comments	Download
M	src/scopes.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/codegen-x64.cc	View		1 chunk	+10 lines, -14 lines	0 comments	Download
M	test/mjsunit/eval.js	View		5 chunks	+28 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

http://codereview.chromium.org/523051/diff/1/5 File src/runtime.cc (right): http://codereview.chromium.org/523051/diff/1/5#newcode5249 src/runtime.cc:5249: // Make sure the Make sure the?

10 years, 11 months ago (2010-01-05 09:06:38 UTC) #2

Mads Ager (chromium)

10 years, 11 months ago (2010-01-05 09:23:20 UTC) #3

LGTM

http://codereview.chromium.org/523051/diff/1/5
File src/runtime.cc (right):

http://codereview.chromium.org/523051/diff/1/5#newcode5249
src/runtime.cc:5249: // Make sure the
Please complete comment.

Expand Messages | Collapse Messages