Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5531)

Unified Diff: chrome_frame/test/perf/chrome_frame_perftest.cc

Issue 523040: Some Chrome Frame cleanup:... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_frame/test/html_util_unittests.cc ('k') | chrome_frame/test/util_unittests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/test/perf/chrome_frame_perftest.cc
===================================================================
--- chrome_frame/test/perf/chrome_frame_perftest.cc (revision 35533)
+++ chrome_frame/test/perf/chrome_frame_perftest.cc (working copy)
@@ -133,7 +133,7 @@
OnReadyStateChanged(ready_state);
if (ready_state == READYSTATE_COMPLETE) {
- if(!starting_url_.empty()) {
+ if (!starting_url_.empty()) {
Navigate(starting_url_.c_str());
} else {
PostMessage(WM_CLOSE);
@@ -286,8 +286,9 @@
chrome_dll_ = dir_app_.Append(FILE_PATH_LITERAL("chrome.dll"));
chrome_exe_ = dir_app_.Append(
FilePath::FromWStringHack(chrome::kBrowserProcessExecutableName));
+ chrome_frame_dll_ = dir_app_.Append(FILE_PATH_LITERAL("servers"));
chrome_frame_dll_ = dir_app_.Append(
- FILE_PATH_LITERAL("servers\\npchrome_tab.dll"));
+ FilePath::FromWStringHack(kChromeFrameDllName));
}
virtual void TearDown() {}
@@ -327,7 +328,7 @@
timings[i] = end_time - start_time;
CoFreeUnusedLibraries();
- ASSERT_TRUE(GetModuleHandle(L"npchrome_tab.dll") == NULL);
+ ASSERT_TRUE(GetModuleHandle(kChromeFrameDllName) == NULL);
// TODO(beng): Can't shut down so quickly. Figure out why, and fix. If we
// do, we crash.
@@ -821,7 +822,6 @@
PrintResults(test_name_.c_str());
CoFreeUnusedLibraries();
- //ASSERT_TRUE(GetModuleHandle(L"npchrome_tab.dll") == NULL);
}
void NavigateImpl(const std::string& url) {
« no previous file with comments | « chrome_frame/test/html_util_unittests.cc ('k') | chrome_frame/test/util_unittests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698