Issue 523027: Removing the last remaining vsprops files....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 523027: Removing the last remaining vsprops files.... (Closed)

Created:
10 years, 11 months ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com, kuchhal, brettw+cc_chromium.org

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Removing the last remaining vsprops files (that are hooked in). Also pulling in a newer nacl version. Switching to use AdditionalOptions in list form. BUG=None TEST=None TBR=mmentovai Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35449

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+115 lines, -309 lines)			Patch
M	DEPS	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
M	base/allocator/allocator.gyp	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
M	build/common.gypi	View	1 2 3 4	5 chunks	+18 lines, -9 lines	0 comments	Download
D	build/common.vsprops	View	3 4	1 chunk	+0 lines, -7 lines	0 comments	Download
D	build/debug.vsprops	View		1 chunk	+0 lines, -23 lines	0 comments	Download
D	build/external_code.vsprops	View	1 2 3 4	1 chunk	+0 lines, -14 lines	0 comments	Download
D	build/internal/debug_info.vsprops	View	1 2 3 4	1 chunk	+0 lines, -15 lines	0 comments	Download
D	build/internal/debug_infofastbuild.vsprops	View	1 2 3 4	1 chunk	+0 lines, -15 lines	0 comments	Download
D	build/internal/essential.vsprops	View	1 2 3 4	1 chunk	+0 lines, -76 lines	0 comments	Download
A	build/internal/release_defaults.gypi	View	2 3 4	1 chunk	+15 lines, -0 lines	0 comments	Download
D	build/internal/release_defaults.vsprops	View	1 2 3 4	1 chunk	+0 lines, -25 lines	0 comments	Download
A	build/internal/release_impl.gypi	View	2 3 4	1 chunk	+3 lines, -0 lines	0 comments	Download
D	build/internal/release_impl.vsprops	View	1 2 3 4	1 chunk	+0 lines, -12 lines	0 comments	Download
A	build/internal/release_impl_official.gypi	View		1 chunk	+21 lines, -0 lines	0 comments	Download
D	build/internal/release_impl_official.vsprops	View	1 2 3 4	1 chunk	+0 lines, -27 lines	0 comments	Download
A	build/release.gypi	View		1 chunk	+19 lines, -0 lines	0 comments	Download
D	build/release.vsprops	View	1 2 3 4	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/installer/mini_installer.gyp	View	1 2 3 4	2 chunks	+33 lines, -16 lines	0 comments	Download
D	chrome/installer/mini_installer/mini_installer.vsprops	View	3 4	1 chunk	+0 lines, -31 lines	0 comments	Download
D	chrome/installer/mini_installer/mini_installer_debug.vsprops	View	3 4	1 chunk	+0 lines, -13 lines	0 comments	Download
D	chrome/installer/mini_installer/mini_installer_release.vsprops	View	3 4	1 chunk	+0 lines, -13 lines	0 comments	Download
M	third_party/tcmalloc/tcmalloc.gyp	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

After-holiday rubber-stamp LGTM

Expand Messages | Collapse Messages