Issue 523020: Dropping unneeded set of vsprops....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 523020: Dropping unneeded set of vsprops.... (Closed)

Created:
10 years, 11 months ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Dropping unneeded set of vsprops. These vsprops used to be used to setup the branding #defines. This is now handled in common.gypi. This is an incremental step toward dropping vsprops entirely for release. BUG=None TEST=None TBR=maruel Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35367

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -38 lines)			Patch
M	build/internal/README.chromium	View		1 chunk	+0 lines, -3 lines	0 comments	Download
D	build/internal/chromium_build.vsprops	View		1 chunk	+0 lines, -15 lines	0 comments	Download
D	build/internal/chromium_build_google_chrome.vsprops	View		1 chunk	+0 lines, -15 lines	0 comments	Download
M	build/release.vsprops	View	1	1 chunk	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Great, lgtm

Expand Messages | Collapse Messages