Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2979)

Unified Diff: chrome/browser/resources/net_internals/tabswitcherview.js

Issue 5228004: Switch the about:gpu implementation from an about handler to dom_ui.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/net_internals/tabswitcherview.js
===================================================================
--- chrome/browser/resources/net_internals/tabswitcherview.js (revision 68021)
+++ chrome/browser/resources/net_internals/tabswitcherview.js (working copy)
@@ -22,10 +22,15 @@
*
* @constructor
*/
-function TabSwitcherView(tabHandleView) {
+function TabSwitcherView(tabHandleDivId) {
+ changeClassName(document.getElementById(tabHandleDivId),
arv (Not doing code reviews) 2010/12/06 19:45:57 element.classList.add?
nduca 2010/12/07 01:03:40 Done.
+ 'tab-switcher-view', true);
+ var tabHandleView = new DivView(tabHandleDivId);
+
View.call(this);
this.tabHandleView_ = tabHandleView;
this.tabs_ = [];
+
arv (Not doing code reviews) 2010/12/06 19:45:57 remove empty line
nduca 2010/12/07 01:03:40 Done.
}
inherits(TabSwitcherView, View);
@@ -122,7 +127,8 @@
// Update data needed by newly active tab, as it may be
// significantly out of date.
- g_browser.checkForUpdatedInfo();
+ if(g_browser && g_browser.checkForUpdatedInfo)
arv (Not doing code reviews) 2010/12/06 19:45:57 ws
arv (Not doing code reviews) 2010/12/06 19:45:57 Didn't you rename g_browser?
nduca 2010/12/07 01:03:40 I did for gpu_internals, but gpu_internals browser
+ g_browser.checkForUpdatedInfo();
};
TabSwitcherView.prototype.getAllTabIds = function() {

Powered by Google App Engine
This is Rietveld 408576698