chrome/browser/resources/gpu_internals/info_view.html - Issue 5228004: Switch the about:gpu implementation from an about handler to dom_ui....

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/gpu_internals/info_view.html

Issue 5228004: Switch the about:gpu implementation from an about handler to dom_ui.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/resources/gpu_internals.html ('K') | « chrome/browser/resources/gpu_internals/info_view.css ('k') | chrome/browser/resources/gpu_internals/info_view.js » ('j') | chrome/browser/resources/net_internals/index.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!--

	2 Copyright (c) 2010 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file.

	5 -->

	6 <div id=info-view>

	7 <h3>Chrome Version</h3>

	8 <div id="client-info"></div>

	9 <h3>Driver Information</h3>

	10 <div id="basic-info"></div>

	11

	12 <h3>Diagnostics</h3>

	13 <div id="diagnostics">None</div>

	14

	15 <!-- templates -->

	16 <div style="display:none">

	17 <div id="info-view-table-template">

	18 <table id="info-view-table">

	19 <tr jsselect="value">

	20 <td jsdisplay="!(value instanceof Array)">

	21 <span class="row-title" jscontent="description">title</span>

	22 </td>

	23 <td jsdisplay="!(value instanceof Array)">

	24 <span jscontent="value">value</span>

	25 </td>

	26 <td jsdisplay="value instanceof Array" colspan=2>

	27 <span jscontent="description" class="row-title"></span>
	arv (Not doing code reviews) 2010/12/10 22:19:42 Yup, you are escaping this too much. Just remove a Yup, you are escaping this too much. Just remove all the escaping on the C++ side and use jscontent, textContent (in other words not innerHTML) and you are good. nduca 2010/12/11 00:16:45 Done. Show quoted text On 2010/12/10 22:19:42, arv wrote: > Yup, you are escaping this too much. Just remove all the escaping on the C++ > side and use jscontent, textContent (in other words not innerHTML) and you are > good. Done.
	28 <div transclude="info-view-table-template">

	29 </td>

	30 </tr>

	31 </table>

	32 </div>

	33 </div>

	34 </div>

OLD	NEW