base/utf_offset_string_conversions.cc - Issue 522029: If we can't read a unicode character, write the standard "unknown" (0xFFFD) c...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/utf_offset_string_conversions.cc

Issue 522029: If we can't read a unicode character, write the standard "unknown" (0xFFFD) c... (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/src/

Patch Set: '' Created 11 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/utf_offset_string_conversions.cc

===================================================================

--- base/utf_offset_string_conversions.cc (revision 35352)

+++ base/utf_offset_string_conversions.cc (working copy)

@@ -36,8 +36,7 @@

if (ReadUnicodeCharacter(src, src_len32, &i, &code_point)) {

chars_written = WriteUnicodeCharacter(code_point, output);

} else {

- // TODO(jungshik): consider adding 'Replacement character' (U+FFFD)

- // in place of an invalid codepoint.

+ chars_written = WriteUnicodeCharacter(0xFFFD, output);

success = false;

}

if ((output_offset != std::wstring::npos) &&

« no previous file with comments | « no previous file | base/utf_offset_string_conversions_unittest.cc » ('j') | no next file with comments »