Issue 522015: Faster handling of string indexing using [] with a SMI index....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 522015: Faster handling of string indexing using [] with a SMI index.... (Closed)

Created:
10 years, 12 months ago by fschneider

Modified:
9 years, 6 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Faster handling of string indexing using [] with a SMI index. Instead of falling back to calling GetObjectProperty we call GetCharAt directly if the object is a string and the key in a SMI. Committed: http://code.google.com/p/v8/source/detail?r=3528

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Created: 10 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	src/runtime.cc	View	1	2 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

LGTM. http://codereview.chromium.org/522015/diff/1/2 File src/runtime.cc (right): http://codereview.chromium.org/522015/diff/1/2#newcode2778 src/runtime.cc:2778: } else if (args[0]->IsString() && Fits nicely on ...

10 years, 12 months ago (2009-12-28 12:52:46 UTC) #2

fschneider

10 years, 12 months ago (2009-12-28 13:00:29 UTC) #3

http://codereview.chromium.org/522015/diff/1/2
File src/runtime.cc (right):

http://codereview.chromium.org/522015/diff/1/2#newcode2778
src/runtime.cc:2778: } else if (args[0]->IsString() &&
On 2009/12/28 12:52:46, Kasper Lund wrote:
> Fits nicely on one line, right?

Done.

http://codereview.chromium.org/522015/diff/1/2#newcode2780
src/runtime.cc:2780: // Fast case for string indexing using [] with a SMI index.
On 2009/12/28 12:52:46, Kasper Lund wrote:
> SMI -> Smi or smi

Done.

Expand Messages | Collapse Messages