chrome/browser/policy/device_management_policy_cache_unittest.cc - Issue 5219006: Refresh policies from DM server periodically

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/device_management_policy_cache_unittest.cc

Issue 5219006: Refresh policies from DM server periodically (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address comments Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/policy/device_management_policy_cache.cc ('k') | chrome/browser/policy/device_management_policy_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/device_management_policy_cache_unittest.cc

diff --git a/chrome/browser/policy/device_management_policy_cache_unittest.cc b/chrome/browser/policy/device_management_policy_cache_unittest.cc

index 6654d38ce5e957a0ab45252de46b594045372f99..45e78fc2829fdd664ed36ff699ec1a7592011e77 100644

--- a/chrome/browser/policy/device_management_policy_cache_unittest.cc

+++ b/chrome/browser/policy/device_management_policy_cache_unittest.cc

@@ -134,7 +134,10 @@ TEST_F(DeviceManagementPolicyCacheTest, SetPolicy) {

DeviceManagementPolicyCache cache(test_file());

em::DevicePolicyResponse policy;

AddStringPolicy(&policy, "HomepageLocation", "http://www.example.com");

- cache.SetPolicy(policy);

+ EXPECT_TRUE(cache.SetPolicy(policy));

+ em::DevicePolicyResponse policy2;

+ AddStringPolicy(&policy2, "HomepageLocation", "http://www.example.com");

+ EXPECT_FALSE(cache.SetPolicy(policy2));

DictionaryValue expected;

expected.Set("HomepageLocation",

Value::CreateStringValue("http://www.example.com"));

@@ -147,14 +150,14 @@ TEST_F(DeviceManagementPolicyCacheTest, ResetPolicy) {

em::DevicePolicyResponse policy;

AddStringPolicy(&policy, "HomepageLocation", "http://www.example.com");

- cache.SetPolicy(policy);

+ EXPECT_TRUE(cache.SetPolicy(policy));

DictionaryValue expected;

expected.Set("HomepageLocation",

Value::CreateStringValue("http://www.example.com"));

scoped_ptr<Value> policy_value(cache.GetPolicy());

EXPECT_TRUE(expected.Equals(policy_value.get()));

- cache.SetPolicy(em::DevicePolicyResponse());

+ EXPECT_TRUE(cache.SetPolicy(em::DevicePolicyResponse()));

policy_value.reset(cache.GetPolicy());

DictionaryValue empty;

EXPECT_TRUE(empty.Equals(policy_value.get()));

@@ -189,7 +192,7 @@ TEST_F(DeviceManagementPolicyCacheTest, FreshPolicyOverride) {

em::DevicePolicyResponse updated_policy;

AddStringPolicy(&updated_policy, "HomepageLocation",

"http://www.chromium.org");

- cache.SetPolicy(updated_policy);

+ EXPECT_TRUE(cache.SetPolicy(updated_policy));

cache.LoadPolicyFromFile();

DictionaryValue expected;