Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 5217005: RTL HTML/CSS clean-up with -webkit-foo-{start,end}... (Closed)

Created:
10 years, 1 month ago by jungshik at Google
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, arv (Not doing code reviews), pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

RTL HTML/CSS clean-up with -webkit-foo-{start,end} With -webkit-{margin,padding}-{start,end}, a lot of dir=rtl pseudo-selectors can be removed. While I'm at it, I fixed one glitch in the history page where 'text-align: right' is hard-coded instead of 'text-align: end' BUG=NONE TEST=extension/download/plugin/history and DOM UI pages are laid out as before both in LTR CHrome and RTL Chrome. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68364

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -143 lines) Patch
M chrome/browser/resources/about_conflicts.html View 3 chunks +3 lines, -17 lines 0 comments Download
M chrome/browser/resources/about_sys.html View 1 chunk +2 lines, -10 lines 0 comments Download
M chrome/browser/resources/dom_ui.css View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/dom_ui2.css View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/downloads.html View 1 3 chunks +5 lines, -22 lines 0 comments Download
M chrome/browser/resources/extensions_ui.html View 4 chunks +5 lines, -28 lines 0 comments Download
M chrome/browser/resources/history.html View 3 chunks +4 lines, -10 lines 0 comments Download
M chrome/browser/resources/imageburner.html View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/plugins.html View 7 chunks +8 lines, -47 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jungshik at Google
10 years, 1 month ago (2010-11-20 01:25:59 UTC) #1
arv (Not doing code reviews)
10 years, 1 month ago (2010-11-22 19:18:33 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698