Issue 5217002: [gtk] don't show custom frame min/max/close when theme is changed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5217002: [gtk] don't show custom frame min/max/close when theme is changed. (Closed)

Created:
10 years, 1 month ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[gtk] don't show custom frame min/max/close when theme is changed. BUG=63661 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66705

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	chrome/browser/gtk/browser_titlebar.cc	View		2 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

10 years, 1 month ago (2010-11-18 22:02:24 UTC) #2

LGTM

On Thu, Nov 18, 2010 at 1:25 PM,  <estade@chromium.org> wrote:
> Reviewers: Elliot Glaysher,
>
> Description:
> [gtk] don't show custom frame min/max/close when theme is changed.
>
> BUG=63661
> TEST=manual
>
> Please review this at http://codereview.chromium.org/5217002/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/browser/gtk/browser_titlebar.cc
>
>
> Index: chrome/browser/gtk/browser_titlebar.cc
> diff --git a/chrome/browser/gtk/browser_titlebar.cc
> b/chrome/browser/gtk/browser_titlebar.cc
> index
>
995f04776565552ea892376722a46eaa4dc2c82e..71c8571988fe344df95ae9cf13f552c122f18433
> 100644
> --- a/chrome/browser/gtk/browser_titlebar.cc
> +++ b/chrome/browser/gtk/browser_titlebar.cc
> @@ -468,8 +468,10 @@ void BrowserTitlebar::BuildButtons(const std::string&
> button_string) {
>   }
>
>   // Now show the correct widgets in the two hierarchies.
> -  gtk_widget_show_all(titlebar_left_buttons_vbox_);
> -  gtk_widget_show_all(titlebar_right_buttons_vbox_);
> +  if (using_custom_frame_) {
> +    gtk_widget_show_all(titlebar_left_buttons_vbox_);
> +    gtk_widget_show_all(titlebar_right_buttons_vbox_);
> +  }
>   UpdateMaximizeRestoreVisibility();
>  }
>
> @@ -522,9 +524,9 @@ void BrowserTitlebar::UpdateCustomFrame(bool
> use_custom_frame) {
>   using_custom_frame_ = use_custom_frame;
>   if (use_custom_frame) {
>     if (titlebar_left_buttons_vbox_)
> -      gtk_widget_show(titlebar_left_buttons_vbox_);
> +      gtk_widget_show_all(titlebar_left_buttons_vbox_);
>     if (titlebar_right_buttons_vbox_)
> -      gtk_widget_show(titlebar_right_buttons_vbox_);
> +      gtk_widget_show_all(titlebar_right_buttons_vbox_);
>   } else {
>     if (titlebar_left_buttons_vbox_)
>       gtk_widget_hide(titlebar_left_buttons_vbox_);
>
>
>

Expand Messages | Collapse Messages