Fix for Bug 50726 "Save extension list and "winning" prefs from extensions"

base/values_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <limits>
 
 #include "base/scoped_ptr.h"
 #include "base/string16.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
@@ skipping 490 matching lines @@
   EXPECT_FALSE(dv.Equals(copy.get()));
 
   // Check if Equals detects differences in only the keys.
   copy.reset(static_cast<DictionaryValue*>(dv.DeepCopy()));
   EXPECT_TRUE(dv.Equals(copy.get()));
   copy->Remove("a", NULL);
   copy->SetBoolean("aa", false);
   EXPECT_FALSE(dv.Equals(copy.get()));
 }
 
+TEST_F(ValuesTest, StaticEquals) {
+  Value* null_ptr = NULL;

[Mattias Nissler (ping if slow), 2010/12/01 10:36:36]

Why have a var for this that even has more characters than the literal NULL?

[battre (please use the other), 2010/12/01 17:44:38]

Done.

+  scoped_ptr<Value> null1(Value::CreateNullValue());
+  scoped_ptr<Value> null2(Value::CreateNullValue());
+  EXPECT_TRUE(Value::Equals(null1.get(), null2.get()));
+  EXPECT_TRUE(Value::Equals(null_ptr, null_ptr));
+
+  scoped_ptr<Value> i42(Value::CreateIntegerValue(42));
+  scoped_ptr<Value> j42(Value::CreateIntegerValue(42));
+  scoped_ptr<Value> i17(Value::CreateIntegerValue(17));
+  EXPECT_TRUE(Value::Equals(i42.get(), i42.get()));
+  EXPECT_TRUE(Value::Equals(j42.get(), i42.get()));
+  EXPECT_TRUE(Value::Equals(i42.get(), j42.get()));
+  EXPECT_FALSE(Value::Equals(i42.get(), i17.get()));
+  EXPECT_FALSE(Value::Equals(i42.get(), null_ptr));
+  EXPECT_FALSE(Value::Equals(null_ptr, i42.get()));
+
+  // NULL and Value::CreateNullValue() are intentionally different: We need
+  // support for NULL as a return value for "undefined" without caring for
+  // ownership of the pointer.
+  EXPECT_FALSE(Value::Equals(null1.get(), null_ptr));
+  EXPECT_FALSE(Value::Equals(null_ptr, null1.get()));
+}
+
 TEST_F(ValuesTest, RemoveEmptyChildren) {
   scoped_ptr<DictionaryValue> root(new DictionaryValue);
   // Remove empty lists and dictionaries.
   root->Set("empty_dict", new DictionaryValue);
   root->Set("empty_list", new ListValue);
   root->SetWithoutPathExpansion("a.b.c.d.e", new DictionaryValue);
   root.reset(root->DeepCopyWithoutEmptyChildren());
   EXPECT_TRUE(root->empty());
 
   // Make sure we don't prune too much.
@@ skipping 210 matching lines @@
     "s1",
     "s1.s2"
   };
   dict1.reset(new DictionaryValue());
   dict1->Set("s1.s2", new DictionaryValue());
   dict2.reset(new DictionaryValue());
   dict2->SetInteger("s1", 1);
   CompareDictionariesAndCheckResult(dict1.get(), dict2.get(), expected_paths8,
                                     arraysize(expected_paths8));
 }