Issue 5212005: Make comments about profile pointer in pref_value_store more informative.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5212005: Make comments about profile pointer in pref_value_store more informative. (Closed)

Created:
10 years, 1 month ago by Mattias Nissler (ping if slow)

Modified:
9 years, 7 months ago

Reviewers:
markusheintz_

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Make comments about profile pointer in pref_value_store more informative. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66930

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -10 lines)			Patch
	M	chrome/browser/policy/device_token_fetcher.h	View		1 chunk	+3 lines, -5 lines	0 comments	Download
	M	chrome/browser/prefs/pref_value_store.h	View		2 chunks	+9 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

Mattias Nissler (ping if slow)

Sorry for committing the previous CL without taking care of the comments, I just screwed ...

10 years, 1 month ago (2010-11-19 11:06:22 UTC) #1

Mattias Nissler (ping if slow)

Updated version, please have a look whether you like the wording.

10 years, 1 month ago (2010-11-19 11:44:17 UTC) #2

markusheintz_

10 years, 1 month ago (2010-11-19 12:48:16 UTC) #3

LGTM

GREAT!!! I LIKE THE COMMENTS!!! THANKS!

Now even I can get it ;-).