views/controls/menu/native_menu_gtk.h - Issue 521063: Fixes possible crash in menus on views/gtk. The crash would happen if...

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: views/controls/menu/native_menu_gtk.h

Issue 521063: Fixes possible crash in menus on views/gtk. The crash would happen if... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 10 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. Use of this	1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. Use of this

2 // source code is governed by a BSD-style license that can be found in the	2 // source code is governed by a BSD-style license that can be found in the

3 // LICENSE file.	3 // LICENSE file.

4	4

5 #ifndef VIEWS_CONTROLS_MENU_NATIVE_MENU_GTK_H_	5 #ifndef VIEWS_CONTROLS_MENU_NATIVE_MENU_GTK_H_

6 #define VIEWS_CONTROLS_MENU_NATIVE_MENU_GTK_H_	6 #define VIEWS_CONTROLS_MENU_NATIVE_MENU_GTK_H_

7	7

8 #include <gtk/gtk.h>	8 #include <gtk/gtk.h>

9	9

10 #include "views/controls/menu/menu_wrapper.h"	10 #include "views/controls/menu/menu_wrapper.h"

(...skipping 45 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
56	56

57 GtkWidget* menu_;	57 GtkWidget* menu_;

58	58

59 bool menu_shown_;	59 bool menu_shown_;

60	60

61 // A flag used to avoid misfiring ActivateAt call on the menu model.	61 // A flag used to avoid misfiring ActivateAt call on the menu model.

62 // This is necessary as GTK menu fires an activate signal even when the	62 // This is necessary as GTK menu fires an activate signal even when the

63 // state is changed by \|UpdateStates()\| API.	63 // state is changed by \|UpdateStates()\| API.

64 bool suppress_activate_signal_;	64 bool suppress_activate_signal_;

65	65

	66 // Did the user select something from the menu?

	67 bool menu_activated_;

	68

	69 // If menu_activated_ is true, this is the index of the item.

	70 int activated_index_;

	71

66 DISALLOW_COPY_AND_ASSIGN(NativeMenuGtk);	72 DISALLOW_COPY_AND_ASSIGN(NativeMenuGtk);

67 };	73 };

68	74

69 } // namespace views	75 } // namespace views

70	76

71 #endif // VIEWS_CONTROLS_MENU_NATIVE_MENU_GTK_H_	77 #endif // VIEWS_CONTROLS_MENU_NATIVE_MENU_GTK_H_

OLD	NEW

« no previous file with comments | « no previous file | views/controls/menu/native_menu_gtk.cc » ('j') | no next file with comments »