Issue 521057: Inline a number of simple date computations....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 521057: Inline a number of simple date computations.... (Closed)

Created:
10 years, 11 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Inline a number of simple date computations. The minifier has been updated to have better recognition of regular expressions. Committed: http://code.google.com/p/v8/source/detail?r=3565

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -98 lines)			Patch
M	src/date-delay.js	View	1	29 chunks	+59 lines, -97 lines	0 comments	Download
M	src/macros.py	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	tools/jsmin.py	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM I wonder what it does to the executable size (with snapshot). http://codereview.chromium.org/521057/diff/1/4 File src/date-delay.js ...

10 years, 11 months ago (2010-01-07 14:39:07 UTC) #2

Mads Ager (chromium)

10 years, 11 months ago (2010-01-08 07:35:12 UTC) #3

http://codereview.chromium.org/521057/diff/1/4
File src/date-delay.js (right):

http://codereview.chromium.org/521057/diff/1/4#newcode223
src/date-delay.js:223: // Inline the DST offset cache checks for speed.
On 2010/01/07 14:39:07, Erik Corry wrote:
> This looks wrong.

It is right though.  This is inlining a fast path of
DaylightSavingsOffset(time).  I'll make the code a bit clearer.

http://codereview.chromium.org/521057/diff/1/2
File tools/jsmin.py (right):

http://codereview.chromium.org/521057/diff/1/2#newcode235
tools/jsmin.py:235: slash_quoted_regexp =
r"/(?:(?=\()|(?:[^()/\\]|\\.)+)(?:\([^/\\]|\\.)+/"
On 2010/01/07 14:39:07, Erik Corry wrote:
> This isn't quite right (mea culpa).  It doesn't recognize regexps without
braces
> in them.  Does it still work with a * at the end instead of a + ?

It does, yes. Done.

Expand Messages | Collapse Messages