Issue 521049: Shard WorkerFastLayoutTests to avoid Flakiness.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 521049: Shard WorkerFastLayoutTests to avoid Flakiness. (Closed)

Created:
10 years, 11 months ago by awong

Modified:
9 years, 7 months ago

Reviewers:
Dmitry Titov

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Shard WorkerFastLayoutTests to avoid Flakiness. This should make it run on reliability on Valgrind UI test bots where the previous grouping was running near the max timeout per test.

Patch Set 1 #

Patch Set 2 : 80-char fix #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -54 lines)			Patch
	M	chrome/worker/worker_uitest.cc	View	1	3 chunks	+76 lines, -54 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dmitry Titov

10 years, 11 months ago (2010-01-06 23:34:56 UTC) #2

I would add a static bool to avoid multiple initialization of the test dir (all
the code in RunWorkerFastLayoutTests() function before the 'for' loop)

Otherwise LGTM. Thanks for doing this!

Expand Messages | Collapse Messages