Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 5206007: AU: Make sure that subsequent non-Terminator unit tests don't exit. (Closed)

Created:
10 years, 1 month ago by petkov
Modified:
9 years, 7 months ago
Reviewers:
adlr
CC:
chromium-os-reviews_chromium.org, petkov, adlr
Visibility:
Public.

Description

AU: Make sure that subsequent non-Terminator unit tests don't exit. This didn't seem to cause an issue but it's better to be safe. BUG=6243 TEST=unit tests Change-Id: Ifdd73ba2f18f2b92944b448803c1447131a3d74d Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=0a9a6ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M terminator_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
petkov
10 years, 1 month ago (2010-11-19 23:24:31 UTC) #1
adlr
10 years, 1 month ago (2010-11-19 23:31:07 UTC) #2
LGTM

On Fri, Nov 19, 2010 at 3:24 PM, <petkov@chromium.org> wrote:

> Reviewers: adlr,
>
> Description:
> AU: Make sure that subsequent non-Terminator unit tests don't exit.
>
> This didn't seem to cause an issue but it's better to be safe.
>
> BUG=6243
> TEST=unit tests
>
> Change-Id: Ifdd73ba2f18f2b92944b448803c1447131a3d74d
>
> Please review this at http://codereview.chromium.org/5206007/
>
> SVN Base: ssh://git@gitrw.chromium.org:9222/update_engine.git@master
>
> Affected files:
>  M terminator_unittest.cc
>
>
> Index: terminator_unittest.cc
> diff --git a/terminator_unittest.cc b/terminator_unittest.cc
> index
>
e1fb5734ae0b23215bc00fa9e79f243b3cfec758..8582b99e705a35d08b92353e209dc76702107cb4
> 100644
> --- a/terminator_unittest.cc
> +++ b/terminator_unittest.cc
> @@ -19,6 +19,11 @@ class TerminatorTest : public ::testing::Test {
>     ASSERT_FALSE(Terminator::exit_blocked());
>     ASSERT_FALSE(Terminator::exit_requested());
>   }
> +  virtual void TearDown() {
> +    // Makes sure subsequent non-Terminator tests don't get accidentally
> +    // terminated.
> +    Terminator::Init();
> +  }
>  };
>
>  typedef TerminatorTest TerminatorDeathTest;
>
>
>

Powered by Google App Engine
This is Rietveld 408576698