Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 5206002: Fix context menus for touchui=1 (Closed)

Created:
10 years, 1 month ago by sadrul
Modified:
9 years, 6 months ago
Reviewers:
oshima
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

Fix context menus for touchui=1 Nested tasks are generally allowed for context menus (e.g. in MenuController::Run, NativeMenuDOMUI::RunMenuAt). Do the same here. This fixes a X-freeze caused by context menus when touchui=1 with the X message-pump. BUG=none TEST=manual, context menus in web-pages should work and not freeze X. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66621

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M views/controls/menu/native_menu_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
sadrul
10 years, 1 month ago (2010-11-18 05:58:58 UTC) #1
oshima
views menu and domui menu allows nested task for reason. one qq before lgtm. I ...
10 years, 1 month ago (2010-11-18 06:59:13 UTC) #2
sadrul
On 2010/11/18 06:59:13, oshima wrote: > views menu and domui menu allows nested task for ...
10 years, 1 month ago (2010-11-18 13:30:52 UTC) #3
oshima
10 years, 1 month ago (2010-11-18 15:05:21 UTC) #4
LGTM

On Thu, Nov 18, 2010 at 5:30 AM, <sadrul@chromium.org> wrote:

> On 2010/11/18 06:59:13, oshima wrote:
>
>> views menu and domui menu allows nested task for reason.
>> one qq before lgtm. I thought touch is not using gtk. Am I wrong?
>>
>
> You are correct. GTK+ is being replaced for touchui. While this transition
> is
> happening, there are still some parts that use GTK+, context menus being
> one of
> them. Until it gets replaced, the new message-pump for touchui is somewhat
> unusable because context menus cause the entire X to freeze. So this is an
> attempt to make it usable during this transition phase. :)


Got it. Thank you for clarification.

- oshima

>
>
> http://codereview.chromium.org/5206002/
>

Powered by Google App Engine
This is Rietveld 408576698