Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 52040: Chrome changes to support cached form submissions.... (Closed)

Created:
11 years, 9 months ago by darin (slow to review)
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Chrome changes to support cached form submissions. The solution is to add a user-defined identifier to UploadData. If that identifier is set, and if the request method is POST, then HttpCache will enable caching for the response. (The cache key will be a composition of the identifier and the URL.) A subsequent POST request to the same URL with the same identifier will "hit" the previously generated cache entry. Reuse from the cache is subject to all of the standard rules. For reference, here are the corresponding net changes: http://codereview.chromium.org/52028 Here are the corresponding WebKit changes: http://trac.webkit.org/changeset/41919 BUG=2636 R=sky Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12485

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -28 lines) Patch
M chrome/browser/renderer_host/resource_dispatcher_host.cc View 1 2 3 2 chunks +13 lines, -13 lines 0 comments Download
M chrome/common/render_messages.h View 1 2 3 4 4 chunks +37 lines, -4 lines 0 comments Download
M chrome/common/resource_dispatcher.cc View 1 2 3 2 chunks +15 lines, -4 lines 0 comments Download
M webkit/glue/glue_serialize.cc View 1 2 3 7 chunks +18 lines, -7 lines 2 comments Download
M webkit/glue/resource_handle_impl.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/resource_loader_bridge.h View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M webkit/glue/weburlrequest_impl.cc View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/simple_resource_loader_bridge.cc View 3 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
darin (slow to review)
11 years, 9 months ago (2009-03-24 17:59:18 UTC) #1
sky
LGTM with one suggestion. http://codereview.chromium.org/52040/diff/2019/1010 File webkit/glue/glue_serialize.cc (right): http://codereview.chromium.org/52040/diff/2019/1010#newcode90 Line 90: int64 tmp; should you ...
11 years, 9 months ago (2009-03-24 20:34:40 UTC) #2
darin (slow to review)
11 years, 9 months ago (2009-03-24 21:12:15 UTC) #3
http://codereview.chromium.org/52040/diff/2019/1010
File webkit/glue/glue_serialize.cc (right):

http://codereview.chromium.org/52040/diff/2019/1010#newcode90
Line 90: int64 tmp;
Good idea!

Powered by Google App Engine
This is Rietveld 408576698