Issue 5203002: Prepare push to trunk. Now working on version 2.5.8.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5203002: Prepare push to trunk. Now working on version 2.5.8. (Closed)

Created:
10 years, 1 month ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Prepare push to trunk. Now working on version 2.5.8. Committed: http://code.google.com/p/v8/source/detail?r=5848

Patch Set 1 #

Total comments: 6

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -1 line)			Patch
	M	ChangeLog	View		1 chunk	+25 lines, -0 lines	6 comments	Download
	M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM with a couple of nits in the ChangeLog. http://codereview.chromium.org/5203002/diff/1/ChangeLog File ChangeLog (right): http://codereview.chromium.org/5203002/diff/1/ChangeLog#newcode4 ChangeLog:4: ...

10 years, 1 month ago (2010-11-18 10:09:08 UTC) #2

Erik Corry

10 years, 1 month ago (2010-11-18 10:23:19 UTC) #3

http://codereview.chromium.org/5203002/diff/1/ChangeLog
File ChangeLog (right):

http://codereview.chromium.org/5203002/diff/1/ChangeLog#newcode4
ChangeLog:4: http://code.google.com/p/v8/issues/detail?id=931
On 2010/11/18 10:09:08, Mads Ager wrote:
> We normally just write '(issue 931).'

Done.

http://codereview.chromium.org/5203002/diff/1/ChangeLog#newcode6
ChangeLog:6: Spilt the random number state between JavaScript and the private
API.
On 2010/11/18 10:09:08, Mads Ager wrote:
> Spilt -> Split.

Done.

http://codereview.chromium.org/5203002/diff/1/ChangeLog#newcode14
ChangeLog:14: Provide more accurate results about used heap size via
On 2010/11/18 10:09:08, Mads Ager wrote:
> Past tense in all items?

But we never stopped providing more accurate results about used heap size! :-)

(Normally we use the past tense for things we did to the VM, but the present
tense for things the VM is now doing.)

Expand Messages | Collapse Messages