Add a new C++ pointer wrapping API to External to not dilute the...

test/cctest/test-api.cc

 // Copyright 2007-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1324 matching lines @@
   env->Global()->Set(v8_str("ext"), ext);
   Local<Value> reext_obj = Script::Compile(v8_str("this.ext"))->Run();
   v8::Handle<v8::External> reext = v8::Handle<v8::External>::Cast(reext_obj);
   int* ptr = static_cast<int*>(reext->Value());
   CHECK_EQ(x, 3);
   *ptr = 10;
   CHECK_EQ(x, 10);
 
   // Make sure unaligned pointers are wrapped properly.
   char* data = i::StrDup("0123456789");
-  Local<v8::External> zero = v8::External::New(&data[0]);
-  Local<v8::External> one = v8::External::New(&data[1]);
-  Local<v8::External> two = v8::External::New(&data[2]);
-  Local<v8::External> three = v8::External::New(&data[3]);
+  Local<v8::Value> zero = v8::External::Wrap(&data[0]);
+  Local<v8::Value> one = v8::External::Wrap(&data[1]);
+  Local<v8::Value> two = v8::External::Wrap(&data[2]);
+  Local<v8::Value> three = v8::External::Wrap(&data[3]);
 
-  char* char_ptr = reinterpret_cast<char*>(zero->Value());
+  char* char_ptr = reinterpret_cast<char*>(v8::External::Unwrap(zero));
   CHECK_EQ('0', *char_ptr);
-  char_ptr = reinterpret_cast<char*>(one->Value());
+  char_ptr = reinterpret_cast<char*>(v8::External::Unwrap(one));
   CHECK_EQ('1', *char_ptr);
-  char_ptr = reinterpret_cast<char*>(two->Value());
+  char_ptr = reinterpret_cast<char*>(v8::External::Unwrap(two));
   CHECK_EQ('2', *char_ptr);
-  char_ptr = reinterpret_cast<char*>(three->Value());
+  char_ptr = reinterpret_cast<char*>(v8::External::Unwrap(three));
   CHECK_EQ('3', *char_ptr);
   i::DeleteArray(data);
 }
 
 
 THREADED_TEST(GlobalHandle) {
   v8::Persistent<String> global;
   {
     v8::HandleScope scope;
     Local<String> str = v8_str("str");
@@ skipping 4721 matching lines @@
 
   // Local context should still be live.
   CHECK(!local_env.IsEmpty());
   local_env->Enter();
 
   // Should complete without problems.
   RegExpStringModificationTest().RunTest();
 
   local_env->Exit();
 }