Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1288)

Issue 5202001: Move definitions to support various unices into its own file.... (Closed)

Created:
10 years, 1 month ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
brettw, Evan Martin
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Remove a definition in a weird spot since it's only used on Solaris, which nobody is actively porting to right now. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66578

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M base/process_util.h View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
Evan added this code for an external contributor working on Solaris support a while back. ...
10 years, 1 month ago (2010-11-17 22:47:03 UTC) #1
Evan Martin
Since the Solaris guy disappeared, I'd just as well remove it as support it.
10 years, 1 month ago (2010-11-17 22:48:58 UTC) #2
Lei Zhang
On 2010/11/17 22:48:58, Evan Martin wrote: > Since the Solaris guy disappeared, I'd just as ...
10 years, 1 month ago (2010-11-18 01:17:54 UTC) #3
brettw
I agree, I'd prefer to remove any code that's not being actively maintained. Brett On ...
10 years, 1 month ago (2010-11-18 01:35:02 UTC) #4
Lei Zhang
On 2010/11/18 01:35:02, brettw wrote: > I agree, I'd prefer to remove any code that's ...
10 years, 1 month ago (2010-11-18 01:40:44 UTC) #5
Evan Martin
10 years, 1 month ago (2010-11-18 01:53:47 UTC) #6
LG

Powered by Google App Engine
This is Rietveld 408576698