Issue 52010: Reapply portability fixes, this time without 64 bit system bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 52010: Reapply portability fixes, this time without 64 bit system bug. (Closed)

Created:
11 years, 9 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Reapply portability fixes, this time without 64 bit system bug.

Patch Set 1 #

Total comments: 3

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+83 lines, -8 lines)			Patch
M	SConstruct	View	9 chunks	+69 lines, -6 lines	2 comments	Download
M	src/SConscript	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/execution.cc	View	1 chunk	+2 lines, -1 line	1 comment	Download
M	src/platform-linux.cc	View	5 chunks	+10 lines, -0 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

11 years, 9 months ago (2009-03-23 10:50:36 UTC) #2

http://codereview.chromium.org/52010/diff/1/6
File SConstruct (right):

http://codereview.chromium.org/52010/diff/1/6#newcode37
Line 37: 
Please add a comment on where this TOP environment variable is used and for what
purpose. Maybe rename it in the scons file to ANDROID_TOP.

http://codereview.chromium.org/52010/diff/1/6#newcode296
Line 296: },
Isn't all this stuff required for building mksnapshot and the D8 shell as well?

http://codereview.chromium.org/52010/diff/1/5
File src/execution.cc (right):

http://codereview.chromium.org/52010/diff/1/5#newcode486
Line 486: Object* result = 0;
0 -> NULL.

Expand Messages | Collapse Messages