Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 520004: Moved debootstrap phase from build_image.sh to install_packages.sh. (Closed)

Created:
11 years ago by tedbo
Modified:
9 years, 7 months ago
Reviewers:
Bill Richardson
CC:
chromium-os-reviews_googlegroups.com
Visibility:
Public.

Description

Moved debootstrap phase from build_image.sh to install_packages.sh. This puts all package installation for the rootfs in one place. It also makes it so that you can run install_packages.sh --root="foo" outside of the build_image.sh script if you want to test something without going through the full image build. With this change build_image basically: - Sets up a loopback mounted rootfs - Calls install_packages.sh on rootfs - Calls customize_rootfs on rootfs - Makes the rootfs bootable

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed flag defaults. Moved bootchart. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -97 lines) Patch
M src/package_repo/package-list-prod.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M src/scripts/build_image.sh View 1 4 chunks +4 lines, -66 lines 0 comments Download
M src/scripts/install_packages.sh View 1 5 chunks +90 lines, -31 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tedbo
11 years ago (2009-12-23 22:58:05 UTC) #1
Bill Richardson
http://codereview.chromium.org/520004/diff/1/3 File src/scripts/install_packages.sh (right): http://codereview.chromium.org/520004/diff/1/3#newcode29 src/scripts/install_packages.sh:29: DEFINE_string output_dir "$(pwd)" \ Do we really want to ...
11 years ago (2009-12-23 23:07:35 UTC) #2
Bill Richardson
11 years ago (2009-12-23 23:56:10 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698