Issue 520001: Fix utf8 issue in extension action context menu....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 520001: Fix utf8 issue in extension action context menu.... (Closed)

Created:
11 years ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews_googlegroups.com, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Fix utf8 issue in extension action context menu. BUG=29538 TEST=Extensions with utf8 encoded names should appear correctly named in the context menu. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35197

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/extensions/extension_action_context_menu_model.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Matt Perry

11 years ago (2009-12-23 00:49:36 UTC) #2

LGTM. I wonder how many other instances of this we have. I remember seeing a bug
about a dialog displaying unicode characters incorrectly.