Change the login name auto completion logic to case sensitive....

chrome/renderer/password_autocomplete_manager_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "app/keyboard_codes.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/renderer/password_autocomplete_manager.h"
 #include "chrome/test/render_view_test.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 20 matching lines @@
 namespace {
 
 // The name of the username/password element in the form.
 const char* const kUsernameName = "username";
 const char* const kPasswordName = "password";
 
 const char* const kAliceUsername = "alice";
 const char* const kAlicePassword = "password";
 const char* const kBobUsername = "bob";
 const char* const kBobPassword = "secret";
+const char* const kChrisUsername = "Chris";

[Ilya Sherman, 2010/11/23 07:16:52]

nit: In the spirit of cryptographic silliness, please use of the names listed
here: http://en.wikipedia.org/wiki/Alice_and_Bob#List_of_characters =)

+const char* const kChrisPassword = "test";
+
 
 const char* const kFormHTML =
     "<FORM name='LoginTestForm' action='http://www.bidule.com'>"
     "  <INPUT type='text' id='username'/>"
     "  <INPUT type='password' id='password'/>"
     "  <INPUT type='submit' value='Login'/>"
     "</FORM>";
 
 class PasswordAutocompleteManagerTest : public RenderViewTest {
  public:
@@ skipping 10 matching lines @@
   }
 
   virtual void SetUp() {
     RenderViewTest::SetUp();
 
     // Add a preferred login and an additional login to the FillData.
     username1_ = ASCIIToUTF16(kAliceUsername);
     password1_ = ASCIIToUTF16(kAlicePassword);
     username2_ = ASCIIToUTF16(kBobUsername);
     password2_ = ASCIIToUTF16(kBobPassword);
+    username3_ = ASCIIToUTF16(kChrisUsername);
+    password3_ = ASCIIToUTF16(kChrisPassword);
 
     fill_data_.basic_data.fields.push_back(
         FormField(string16(), ASCIIToUTF16(kUsernameName),
                   username1_, string16(), 0));
     fill_data_.basic_data.fields.push_back(
         FormField(string16(), ASCIIToUTF16(kPasswordName),
                   password1_, string16(), 0));
     fill_data_.additional_logins[username2_] = password2_;
+    fill_data_.additional_logins[username3_] = password3_;
 
     // We need to set the origin so it matches the frame URL and the action so
     // it matches the form action, otherwise we won't autocomplete.
     std::string origin("data:text/html;charset=utf-8,");
     origin += kFormHTML;
     fill_data_.basic_data.origin = GURL(origin);
     fill_data_.basic_data.action = GURL("http://www.bidule.com");
 
     LoadHTML(kFormHTML);
 
@@ skipping 45 matching lines @@
     EXPECT_EQ(password_autofilled, password_element_.isAutofilled());
   }
 
   void CheckUsernameSelection(int start, int end) {
     EXPECT_EQ(start, username_element_.selectionStart());
     EXPECT_EQ(end, username_element_.selectionEnd());
   }
 
   string16 username1_;
   string16 username2_;
+  string16 username3_;
   string16 password1_;
   string16 password2_;
+  string16 password3_;
   PasswordFormFillData fill_data_;
 
   WebInputElement username_element_;
   WebInputElement password_element_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(PasswordAutocompleteManagerTest);
 };
 
 // Tests that the password login is autocompleted as expected when the browser
@@ skipping 122 matching lines @@
   SimulateKeyDownEvent(username_element_, app::VKEY_A);
 
   // Now lets say the user goes astray from the stored username and types the
   // letter 'f', spelling 'alf'.  We don't know alf (that's just sad), so in
   // practice the username should no longer be 'alice' and the selected range
   // should be empty.
   SimulateUsernameChange("alf", true);
   CheckTextFieldsState("alf", false, "", false);
   CheckUsernameSelection(3, 3);  // No selection.
 
+  // Test case sensetive autocompletion. Check Chris is completed iff the start
+  // charactoer is 'C'.

[Ilya Sherman, 2010/11/23 07:16:52]

nit: This comment would match the surrounding comments better if it were
something like

"""
// Then, the user again removes all the text and types an uppercase 'C'.
SimulateUsernameChange("C", true);
// The username and password fields should match the 'Chris' entry.
"""

"""
// Finally, the user removes all the text and types a lowercase 'c'.  We only
want case-sensitive autocompletion, so the username and the selected range
should be empty."
SimulateUsernameChange("c", true);
"""


Also, please move this code to be below the 'bob' case.

+  SimulateUsernameChange("C", true);
+  CheckTextFieldsState(kChrisUsername, true, kChrisPassword, true);
+  CheckUsernameSelection(1, 5);
+  // And completion is not triggered if the start is 'c'.
+  SimulateUsernameChange("c", true);
+  CheckTextFieldsState("c", false, "", false);
+  CheckUsernameSelection(1, 1);
+
   // Ok, so now the user removes all the text and enters the letter 'b'.
   SimulateUsernameChange("b", true);
   // The username and password fields should match the 'bob' entry.
   CheckTextFieldsState(kBobUsername, true, kBobPassword, true);
   CheckUsernameSelection(1, 3);
 }
 
 // Tests that selecting and item in the suggestion drop-down works.
 TEST_F(PasswordAutocompleteManagerTest, SuggestionSelect) {
   // Simulate the browser sending back the login info.
   SimulateOnFillPasswordForm(fill_data_);
 
   // Clear the textfields to start fresh.
   ClearUsernameAndPasswordFields();
 
   // To simulate a selection in the suggestion drop-down we just mimick what the
   // WebView does: it sets the element value then calls
   // didAcceptAutocompleteSuggestion on the renderer.
   username_element_.setValue(ASCIIToUTF16(kAliceUsername));
   view_->didAcceptAutocompleteSuggestion(username_element_);
 
   // Autocomplete should have kicked in.
   CheckTextFieldsState(kAliceUsername, true, kAlicePassword, true);
 }
 
-}  // namespace
+}