third_party/libxml/src/xpath.c - Issue 5196003: Fix XPath bug from upstream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libxml/src/xpath.c

Issue 5196003: Fix XPath bug from upstream. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/libxml/src/xpath.c

===================================================================

--- third_party/libxml/src/xpath.c (revision 66188)

+++ third_party/libxml/src/xpath.c (working copy)

@@ -11752,11 +11752,15 @@

if ((ctxt->error != XPATH_EXPRESSION_OK) || (res == -1)) {

xmlXPathObjectPtr tmp;

- /* pop the result */

+ /* pop the result if any */

tmp = valuePop(ctxt);

- xmlXPathReleaseObject(xpctxt, tmp);

- /* then pop off contextObj, which will be freed later */

- valuePop(ctxt);

+ if (tmp != contextObj)

+ /*

+ * Free up the result

+ * then pop off contextObj, which will be freed later

+ */

+ xmlXPathReleaseObject(xpctxt, tmp);

+ valuePop(ctxt);

Cris Neckar 2010/11/18 00:53:04 ugly indent

goto evaluation_error;

}

« no previous file with comments | « third_party/libxml/README.chromium ('k') | no next file » | no next file with comments »