Issue 5196003: Fix XPath bug from upstream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5196003: Fix XPath bug from upstream. (Closed)

Created:
10 years, 1 month ago by Chris Evans

Modified:
9 years, 6 months ago

Reviewers:
Cris Neckar

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix XPath bug from upstream. BUG=63444 TEST=See bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66567

Patch Set 1 #

Total comments: 1

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
	M	third_party/libxml/README.chromium	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	third_party/libxml/src/xpath.c	View		1 chunk	+8 lines, -4 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Cris Neckar

LGTM http://codereview.chromium.org/5196003/diff/1/third_party/libxml/src/xpath.c File third_party/libxml/src/xpath.c (right): http://codereview.chromium.org/5196003/diff/1/third_party/libxml/src/xpath.c#newcode11763 third_party/libxml/src/xpath.c:11763: valuePop(ctxt); ugly indent

10 years, 1 month ago (2010-11-18 00:53:04 UTC) #2

Expand Messages | Collapse Messages