Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Issue 5195003: Remove Gay's dtoa from sources. (Closed)

Created:
10 years, 1 month ago by Florian Loitsch
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Remove Gay's dtoa from sources. Farewell. Committed: http://code.google.com/p/v8/source/detail?r=5868

Patch Set 1 #

Patch Set 2 : Added cached-powers.cc to VS files. #

Patch Set 3 : Added files to ARM and x64 VS project files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -3576 lines) Patch
M LICENSE View 1 chunk +0 lines, -3 lines 0 comments Download
M src/SConscript View 1 chunk +1 line, -7 lines 0 comments Download
D src/dtoa-config.c View 1 chunk +0 lines, -92 lines 0 comments Download
D src/third_party/dtoa/COPYING View 1 chunk +0 lines, -15 lines 0 comments Download
D src/third_party/dtoa/dtoa.c View 1 chunk +0 lines, -3331 lines 0 comments Download
M test/cctest/test-conversions.cc View 3 chunks +5 lines, -8 lines 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +1 line, -6 lines 0 comments Download
M tools/visual_studio/README.txt View 1 chunk +1 line, -2 lines 0 comments Download
M tools/visual_studio/v8_base.vcproj View 1 5 chunks +28 lines, -64 lines 0 comments Download
M tools/visual_studio/v8_base_arm.vcproj View 1 2 6 chunks +68 lines, -24 lines 0 comments Download
M tools/visual_studio/v8_base_x64.vcproj View 1 2 6 chunks +68 lines, -24 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Florian Loitsch
10 years, 1 month ago (2010-11-22 14:27:23 UTC) #1
Mads Ager (chromium)
10 years, 1 month ago (2010-11-22 14:30:13 UTC) #2
Please make sure that all of your new files are in the arm and x64 v8_base
targets as well. LGTM.

Powered by Google App Engine
This is Rietveld 408576698