Fixes the remaining net_unittests for OpenSSL, with the exceptions

net/base/x509_openssl_util.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/x509_openssl_util.h"
 
 #include "base/logging.h"
 #include "base/string_number_conversions.h"
 #include "base/string_piece.h"
 #include "base/string_util.h"
@@ skipping 131 matching lines @@
     } else if (c == '-') {
       found_hyphen = true;
     } else if (!IsAsciiDigit(c)) {
       LOG(WARNING) << "Invalid char " << c << " in hostname " << hostname;
       return false;
     }
     reference_name.push_back(c);
   }
   DCHECK(!reference_name.empty());
 
-  // TODO(joth): Add IP address support. See http://crbug.com/62973
+  // TODO(joth): Add full IP address support. See http://crbug.com/62973
   if (found_ip6_chars || !found_alpha) {
+    // Special case localhost connection, to support test server based tests.
+    if (hostname == "127.0.0.1" &&
+        std::find(cert_names.begin(), cert_names.end(), hostname)
+            != cert_names.end()) {
+      DVLOG(1) << "Allowing localhost IP certificate: " << hostname;

[bulach, 2010/12/01 18:01:33]

similar to my comments at http://codereview.chromium.org/4646001/, we should
probably check that we're actually in test mode.

TODO(joth): check TestRootCerts::HasInstance() after
http://codereview.chromium.org/4646001/

[joth, 2010/12/02 17:12:01]

I rolled this comment into the TODO above to support full IP address support.

+      return true;
+    }
     NOTIMPLEMENTED() << hostname;
     return false;
   }
 
   // |wildcard_domain| is the remainder of |host| after the leading host
   // component is stripped off, but includes the leading dot e.g.
   // "www.f.com" -> ".f.com".
   // If there is no meaningful domain part to |host| (e.g. it is an IP address
   // or contains no dots) then |wildcard_domain| will be empty.
   // We required at least 3 components (i.e. 2 dots) as a basic protection
@@ skipping 49 matching lines @@
   }
   DVLOG(1) << "Could not find any match for " << hostname
            << " (canonicalized as " << reference_name
            << ") in cert names " << JoinString(cert_names, '|');
   return false;
 }
 
 } // namespace x509_openssl_util
 
 } // namespace net