Issue 519075: Decrease the number of bootstrap packages in install_packages.sh.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 519075: Decrease the number of bootstrap packages in install_packages.sh. (Closed)

Created:
10 years, 11 months ago by tedbo

Modified:
9 years, 7 months ago

Reviewers:
Bill Richardson

CC:
chromium-os-reviews_googlegroups.com

Visibility:
Public.

Description

Decrease the number of bootstrap packages in install_packages.sh. We use apt to install the majority of our packages. In order to get apt running where it can install packages we first need to force install a small set of packages that have cyclic dependencies. This CL reduces the required set quite a bit and fixes a bug where we were installing a few wrong packages than what we were attempting to install due to a bad glob.

Patch Set 1 #

Total comments: 1

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -15 lines)			Patch
	M	src/scripts/install_packages.sh	View		6 chunks	+23 lines, -15 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bill Richardson

10 years, 11 months ago (2010-01-07 18:25:40 UTC) #2

I made one comment, but it's not a big deal since this is work in progress.
Otherwise LGTM.

http://codereview.chromium.org/519075/diff/1/2
File src/scripts/install_packages.sh (right):

http://codereview.chromium.org/519075/diff/1/2#newcode191
src/scripts/install_packages.sh:191: PKG=$(ls "${REPO}"/${p}_*_i386.deb)
This is for the target filesystem, not the chroot, right?
Shouldn't this be ${FLAGS_target} instead of i386?

Expand Messages | Collapse Messages