Issue 519061: Improve performance of Array.prototype.join and String.prototype.substring...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 519061: Improve performance of Array.prototype.join and String.prototype.substring... (Closed)

Created:
10 years, 11 months ago by Kasper Lund

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Improve performance of Array.prototype.join and String.prototype.substring by tweaking the JavaScript implementation of these functions. Committed: http://code.google.com/p/v8/source/detail?r=3545

Patch Set 1 #

Total comments: 2

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+81 lines, -76 lines)			Patch
M	src/array.js	View	12 chunks	+38 lines, -34 lines	1 comment	Download
M	src/macros.py	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/math.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime.cc	View	1 chunk	+7 lines, -8 lines	0 comments	Download
M	src/runtime.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/string.js	View	4 chunks	+25 lines, -28 lines	0 comments	Download
M	test/mjsunit/fuzz-natives.js	View	2 chunks	+6 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

10 years, 11 months ago (2010-01-06 14:03:57 UTC) #2

LGTM

http://codereview.chromium.org/519061/diff/1/7
File src/array.js (right):

http://codereview.chromium.org/519061/diff/1/7#newcode113
src/array.js:113: if (UseSparseVariant(array, length, is_array) &&
(separator.length == 0)) {
I don't think the extra () around separator.length == 0 really add anything
here.

http://codereview.chromium.org/519061/diff/1/2
File test/mjsunit/fuzz-natives.js (right):

http://codereview.chromium.org/519061/diff/1/2#newcode100
test/mjsunit/fuzz-natives.js:100: // may lead to out-of-memory.
This is somehow unsatisfactory.

Expand Messages | Collapse Messages