Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Side by Side Diff: build/common.gypi

Issue 519034: Use no_strict_aliasing=1 by default. (Closed)
Patch Set: do it for all compilers Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 'variables': { 9 'variables': {
10 # .gyp files should set chromium_code to 1 if they build Chromium-specific 10 # .gyp files should set chromium_code to 1 if they build Chromium-specific
(...skipping 562 matching lines...) Expand 10 before | Expand all | Expand 10 after
573 }], 573 }],
574 ], 574 ],
575 }, 575 },
576 }, 576 },
577 'conditions': [ 577 'conditions': [
578 ['OS=="linux" or OS=="freebsd" or OS=="openbsd"', { 578 ['OS=="linux" or OS=="freebsd" or OS=="openbsd"', {
579 'target_defaults': { 579 'target_defaults': {
580 # Enable -Werror by default, but put it in a variable so it can 580 # Enable -Werror by default, but put it in a variable so it can
581 # be disabled in ~/.gyp/include.gypi on the valgrind builders. 581 # be disabled in ~/.gyp/include.gypi on the valgrind builders.
582 'variables': { 582 'variables': {
583 'no_strict_aliasing%': 0, 583 # Use -fno-strict-aliasing by default since gcc 4.4 has periodic
584 # issues that slip through the cracks. We could do this just for
585 # gcc 4.4 but it makes more sense to be consistent on all
586 # compilers in use. TODO(Craig): turn this off again when
587 # there is some 4.4 test infrastructure in place and existing
588 # aliasing issues have been fixed.
589 'no_strict_aliasing%': 1,
584 'conditions': [['OS=="linux"', {'werror%': '-Werror',}], 590 'conditions': [['OS=="linux"', {'werror%': '-Werror',}],
585 ['OS=="freebsd"', {'werror%': '',}], 591 ['OS=="freebsd"', {'werror%': '',}],
586 ['OS=="openbsd"', {'werror%': '',}], 592 ['OS=="openbsd"', {'werror%': '',}],
587 ], 593 ],
588 }, 594 },
589 'cflags': [ 595 'cflags': [
590 '<(werror)', # See note above about the werror variable. 596 '<(werror)', # See note above about the werror variable.
591 '-pthread', 597 '-pthread',
592 '-fno-exceptions', 598 '-fno-exceptions',
593 '-Wall', 599 '-Wall',
(...skipping 563 matching lines...) Expand 10 before | Expand all | Expand 10 after
1157 # and therefore SYMROOT, needs to be set at the project level. 1163 # and therefore SYMROOT, needs to be set at the project level.
1158 'SYMROOT': '<(DEPTH)/xcodebuild', 1164 'SYMROOT': '<(DEPTH)/xcodebuild',
1159 }, 1165 },
1160 } 1166 }
1161 1167
1162 # Local Variables: 1168 # Local Variables:
1163 # tab-width:2 1169 # tab-width:2
1164 # indent-tabs-mode:nil 1170 # indent-tabs-mode:nil
1165 # End: 1171 # End:
1166 # vim: set expandtab tabstop=2 shiftwidth=2: 1172 # vim: set expandtab tabstop=2 shiftwidth=2:
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698