Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 519030: bsds: views/ and webkit/ support for FreeBSD/OpenBSD (Closed)

Created:
10 years, 11 months ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
agl
CC:
chromium-reviews_googlegroups.com, fbarchard, ben+cc_chromium.org, Alpha Left Google, jam, pam+watch_chromium.org, awong, Paweł Hajdan Jr., darin (slow to review), scherkus (not reviewing)
Visibility:
Public.

Description

bsds: views/ and webkit/ support for FreeBSD/OpenBSD - add a TOOLKIT_USES_GTK #define to catch GTK and Views+GTK - lots of ifdef twiddling Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35402

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -74 lines) Patch
M build/build_config.h View 1 chunk +6 lines, -0 lines 0 comments Download
M views/view.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/views.gyp View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/default_plugin/plugin_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/glue/plugins/nphostapi.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/plugins/plugin_host.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M webkit/glue/plugins/plugin_lib.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/glue/plugins/plugin_lib.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/glue/plugins/plugin_list.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/glue/plugins/test/plugin_javascript_open_popup.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/glue/resource_fetcher_unittest.cc View 5 chunks +9 lines, -8 lines 0 comments Download
M webkit/glue/webclipboard_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webdevtoolsfrontend_impl.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M webkit/glue/webkit_glue.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M webkit/glue/webkit_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webkitclient_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/tools/layout_tests/layout_package/platform_utils.py View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/npapi_layout_test_plugin/main.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M webkit/tools/test_shell/keyboard_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/media_leak_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/mock_webclipboard_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
webkit/tools/test_shell/plugin_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gyp View 8 chunks +8 lines, -8 lines 0 comments Download
M webkit/tools/test_shell/test_shell_request_context.cc View 2 chunks +2 lines, -1 line 1 comment Download
M webkit/tools/test_shell/test_webview_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/webview_host.h View 3 chunks +4 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/webwidget_host.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Martin
10 years, 11 months ago (2009-12-30 23:08:47 UTC) #1
agl
10 years, 11 months ago (2009-12-30 23:12:55 UTC) #2 
LGTM

http://codereview.chromium.org/519030/diff/1/26
File webkit/tools/test_shell/test_shell_request_context.cc (right):

http://codereview.chromium.org/519030/diff/1/26#newcode48
webkit/tools/test_shell/test_shell_request_context.cc:48: // TODO(port): rename
"linux" to some inspecific unix.
"nonspecific"

Powered by Google App Engine
This is Rietveld 408576698