Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 5190005: Fixes a crash in the Windows media player plugin caused when the Real player ... (Closed)

Created:
10 years, 1 month ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
brettw, jam
CC:
chromium-reviews, jam, darin-cc_chromium.org, stuartmorgan+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Fixes a crash in the Windows media player plugin caused when the Real player recorder plugin is installed on the machine. This plugin intercepts LoadLibrary calls issued by chrome.dll and wraps NPAPI calls provided the actual plugin dll, in this case media player. This is to provide the Download this video functionality. Crash occurs probably due to an interacton with Real player and media player. Fix is to load the plugin dynamically via the exported kernel32 function LoadLibrary instead of invoking it via the LoadLibrary import from chrome.dll. This would bypass the recorder plugin. Fixes bug http://code.google.com/p/chromium/issues/detail?id=63552 Bug=63552 Test=Install real player and media player on the machine and navigate to the url mentioned in the bug. It should not crash Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66839

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -3 lines) Patch
M base/native_library.h View 1 chunk +9 lines, -0 lines 0 comments Download
M base/native_library_win.cc View 3 chunks +20 lines, -3 lines 0 comments Download
M webkit/glue/plugins/plugin_lib.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ananta
10 years, 1 month ago (2010-11-19 19:40:05 UTC) #1
jam
lgtm to fix the crash in the short term i don't want us to get ...
10 years, 1 month ago (2010-11-19 22:49:36 UTC) #2
brettw
10 years, 1 month ago (2010-11-22 23:54:07 UTC) #3
Is it necessary for this code to be added to base? It doesn't seem like
something anybody else will ever use, so is just bloating base. Can it be moved
to just living in the plugin_lib file in an ifdef?

Powered by Google App Engine
This is Rietveld 408576698