Index: test/cctest/test-parsing.cc |
=================================================================== |
--- test/cctest/test-parsing.cc (revision 5846) |
+++ test/cctest/test-parsing.cc (working copy) |
@@ -27,6 +27,7 @@ |
#include <stdlib.h> |
#include <stdio.h> |
+#include <string.h> |
#include "v8.h" |
@@ -270,3 +271,60 @@ |
CHECK(!data.has_error()); |
} |
} |
+ |
+ |
+TEST(RegressChromium62639) { |
+ int marker; |
+ i::StackGuard::SetStackLimit( |
+ reinterpret_cast<uintptr_t>(&marker) - 128 * 1024); |
+ |
+ const char* program = "var x = 'something';\n" |
+ "escape: function() {}"; |
+ // Fails parsing expecting an identifier after "function". |
+ // Before fix, didn't check *ok after Expect(Token::Identifier, ok), |
+ // and then used the invalid currently scanned literal. This always |
+ // failed in debug mode, and sometimes crashed in release mode. |
+ |
+ unibrow::Utf8InputBuffer<256> stream(program, strlen(program)); |
+ i::ScriptDataImpl* data = |
+ i::ParserApi::PreParse(i::Handle<i::String>::null(), &stream, NULL); |
+ CHECK(data->HasError()); |
+ delete data; |
+} |
+ |
+ |
+TEST(Regress928) { |
+ // Preparsing didn't consider the catch clause of a try statement |
+ // as with-content, which made it assume that a function inside |
+ // the block could be lazily compiled, and an extra, unexpected, |
+ // entry was added to the data. |
+ int marker; |
+ i::StackGuard::SetStackLimit( |
+ reinterpret_cast<uintptr_t>(&marker) - 128 * 1024); |
+ |
+ const char* program = |
+ "try { } catch (e) { var foo = function () { /* first */ } }" |
+ "var bar = function () { /* second */ }"; |
+ |
+ unibrow::Utf8InputBuffer<256> stream(program, strlen(program)); |
+ i::ScriptDataImpl* data = |
+ i::ParserApi::PartialPreParse(i::Handle<i::String>::null(), |
+ &stream, NULL); |
+ CHECK(!data->HasError()); |
+ |
+ data->Initialize(); |
+ |
+ int first_function = strstr(program, "function") - program; |
+ int first_lbrace = first_function + strlen("function () "); |
+ CHECK_EQ('{', program[first_lbrace]); |
+ i::FunctionEntry entry1 = data->GetFunctionEntry(first_lbrace); |
+ CHECK(!entry1.is_valid()); |
+ |
+ int second_function = strstr(program + first_lbrace, "function") - program; |
+ int second_lbrace = second_function + strlen("function () "); |
+ CHECK_EQ('{', program[second_lbrace]); |
+ i::FunctionEntry entry2 = data->GetFunctionEntry(second_lbrace); |
+ CHECK(entry2.is_valid()); |
+ CHECK_EQ('}', program[entry2.end_pos() - 1]); |
+ delete data; |
+} |