Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 5188002: Remove dependency to autotest_run.sh (Closed)

Created:
10 years, 1 month ago by ericli
Modified:
9 years, 7 months ago
Reviewers:
kmixter1
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Remove the dependency to autotest_run.sh so I can get rid of it in next CL. Change-Id: I1032932b696929fccf97f911c555ec5a24f589d4 BUG=9291 TEST=Run storageFio test since it need prebuild test and deps. w/wo emerge autotest w/wo cros_workon in/outside of chroot. and all its combinations. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=983fdb5

Patch Set 1 #

Total comments: 2

Patch Set 2 : patch #

Patch Set 3 : patch #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -89 lines) Patch
D autotest_run.sh View 1 chunk +0 lines, -74 lines 0 comments Download
M run_remote_tests.sh View 1 2 2 chunks +10 lines, -15 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
ericli
10 years, 1 month ago (2010-11-17 23:05:24 UTC) #1
kmixter1
http://codereview.chromium.org/5188002/diff/1/run_remote_tests.sh File run_remote_tests.sh (right): http://codereview.chromium.org/5188002/diff/1/run_remote_tests.sh#newcode274 run_remote_tests.sh:274: export AUTOSERV_TEST_ARGS="${FLAGS_args}" nit: I'd make these local and lowercase ...
10 years, 1 month ago (2010-11-17 23:59:15 UTC) #2
ericli
PTAL. Comments have been addressed and I also include to remove autotest_run.sh in this CL.
10 years, 1 month ago (2010-11-18 01:09:59 UTC) #3
kmixter1
LGTM Make sure to keep an eye on PFQ shortly after you submit since it ...
10 years, 1 month ago (2010-11-18 01:54:38 UTC) #4
ericli
10 years, 1 month ago (2010-11-18 18:26:29 UTC) #5
Ken,
I will leave it as it is in this CL and will change it in my next CL.

Pushing now.

On 2010/11/18 01:54:38, kmixter1 wrote:
> LGTM
> 
> Make sure to keep an eye on PFQ shortly after you submit since it uses the
code
> you modified.
> 
> http://codereview.chromium.org/5188002/diff/7001/run_remote_tests.sh
> File run_remote_tests.sh (right):
> 
>
http://codereview.chromium.org/5188002/diff/7001/run_remote_tests.sh#newcode276
> run_remote_tests.sh:276: autoserv_test_args="-a \"${autoserv_test_args}\""
> nit: You may want to just roll this directly into autoserv_args and avoid
> introducing autoserv_test_args.

Powered by Google App Engine
This is Rietveld 408576698