Issue 5183007: Polish the Enumerate Modules implementation a bit....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5183007: Polish the Enumerate Modules implementation a bit.... (Closed)

Created:
10 years, 1 month ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
huanr

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Polish the Enumerate Modules implementation a bit. 1) De-dup the registered DLLs since a lot of the same DLLs will be registered multiple times, ie. mswsock.dll 2) Every module loaded from a %temp% dir should be viewed as suspicious. 3) Add some histogram counters (xml changes coming in a followup CL). BUG=http://crbug.com/51105 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66880

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -5 lines)			Patch
	M	chrome/browser/enumerate_modules_model_win.h	View		3 chunks	+8 lines, -1 line	0 comments	Download
	M	chrome/browser/enumerate_modules_model_win.cc	View		11 chunks	+72 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages