Issue 5182004: [gtk] use new update badge on wrench menu

Issue 5182004: [gtk] use new update badge on wrench menu (Closed)

Created:
10 years, 1 month ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Finnur

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[gtk] use new update badge on wrench menu get rid of throb animation. BUG=27941 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66676

Patch Set 2 : remove debug code #

Total comments: 1

Patch Set 3 : move to top right #

Total comments: 2

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -108 lines)			Patch
M	chrome/app/theme/theme_resources.grd	View		1 chunk	+0 lines, -2 lines	0 comments	Download
D	chrome/app/theme/upgrade_dot_active.png	View		Binary file		0 comments	Download
D	chrome/app/theme/upgrade_dot_inactive.png	View		Binary file		0 comments	Download
M	chrome/browser/gtk/browser_toolbar_gtk.h	View	1 2	7 chunks	+1 line, -28 lines	2 comments	Download
M	chrome/browser/gtk/browser_toolbar_gtk.cc	View	1 2	8 chunks	+7 lines, -78 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

the badge position isn't pixel perfect. I need a screencap of windows to do that ...

10 years, 1 month ago (2010-11-18 01:18:03 UTC) #1

Finnur

http://codereview.chromium.org/5182004/diff/2001/chrome/browser/gtk/browser_toolbar_gtk.cc File chrome/browser/gtk/browser_toolbar_gtk.cc (right): http://codereview.chromium.org/5182004/diff/2001/chrome/browser/gtk/browser_toolbar_gtk.cc#newcode647 chrome/browser/gtk/browser_toolbar_gtk.cc:647: sender->allocation.y + y_offset); Actually: The badge needs to be ...

10 years, 1 month ago (2010-11-18 10:12:57 UTC) #3

Finnur

Dang, Publish, not Reply! Grrr http://codereview.chromium.org/5182004/diff/8001/chrome/browser/gtk/browser_toolbar_gtk.h File chrome/browser/gtk/browser_toolbar_gtk.h (right): http://codereview.chromium.org/5182004/diff/8001/chrome/browser/gtk/browser_toolbar_gtk.h#newcode13 chrome/browser/gtk/browser_toolbar_gtk.h:13: #include "app/animation_delegate.h" nit: Was ...

10 years, 1 month ago (2010-11-18 20:54:52 UTC) #6

Evan Stade

10 years, 1 month ago (2010-11-18 21:25:47 UTC) #7

http://codereview.chromium.org/5182004/diff/8001/chrome/browser/gtk/browser_t...
File chrome/browser/gtk/browser_toolbar_gtk.h (right):

http://codereview.chromium.org/5182004/diff/8001/chrome/browser/gtk/browser_t...
chrome/browser/gtk/browser_toolbar_gtk.h:13: #include "app/animation_delegate.h"
On 2010/11/18 20:54:52, Finnur wrote:
> nit: Was this needed?

good catch. will fix.

Expand Messages | Collapse Messages