Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 518079: Make sure to use the CHECK_PARSE_ERROR macro (and thereby... (Closed)

Created:
10 years, 11 months ago by Kasper Lund
Modified:
9 years, 7 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Make sure to use the CHECK_PARSE_ERROR macro (and thereby the static CheckParse function) even in release builds. TBR=lrn@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=3564

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M test/cctest/test-regexp.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kasper Lund
10 years, 11 months ago (2010-01-08 06:39:45 UTC) #1
Lasse Reichstein
10 years, 11 months ago (2010-01-08 08:12:19 UTC) #2
LGTM, and sorry.

Powered by Google App Engine
This is Rietveld 408576698