Added ES5 15.2.3.2 Object.getPrototypeOf.

Added ES5 15.2.3.2 Object.getPrototypeOf.


Committed: http://code.google.com/p/v8/source/detail?r=3551

[Christian Plesner Hansen, 2010-01-07 08:32:11]

LGTM

http://codereview.chromium.org/518056/diff/1/3
File src/v8natives.js (right):

http://codereview.chromium.org/518056/diff/1/3#newcode453
src/v8natives.js:453: if (!IS_OBJECT(obj) && !IS_FUNCTION(obj)) {
How about !(IS_OBJECT(obj) || IS_FUNCTION(obj))?

http://codereview.chromium.org/518056/diff/1/5
File test/mjsunit/get-prototype-of.js (right):

http://codereview.chromium.org/518056/diff/1/5#newcode65
test/mjsunit/get-prototype-of.js:65: GetPrototypeOfObject({x:5});
I see no tests for functions here.  Consider adding some.

[Lasse Reichstein, 2010-01-07 09:39:14]

Drive-by comment.

http://codereview.chromium.org/518056/diff/4001/4006
File tools/presubmit.py (right):

http://codereview.chromium.org/518056/diff/4001/4006#newcode224
tools/presubmit.py:224: r'Copyright [\d-]*20[0-1][0-9] the V8 project authors.
All rights reserved.')
If we are going to allow dates in the future, we might as well just make it
"20\d{2}", or even "\d{4}".
Otherwise we need to restrict it to 2008-2010 and update it each year. I
personally prefer the former.

[Christian Plesner Hansen, 2010-01-07 09:42:48]

http://codereview.chromium.org/518056/diff/4001/4006
File tools/presubmit.py (right):

http://codereview.chromium.org/518056/diff/4001/4006#newcode224
tools/presubmit.py:224: r'Copyright [\d-]*20[0-1][0-9] the V8 project authors.
All rights reserved.')
I think [0-1][0-9] is a good compromise between potentially catching mistakes
without making the regexp overly complex.  But I don't have particularly strong
feelings about it.